-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "add Rational64 type (#31gy38v) (#2236)" #2313
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Task linked: CU-31gy38v XCMP fixes |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/d8692e099f630dcb4ae9f1073ea8bb65d28d79aa#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/d8692e099f630dcb4ae9f1073ea8bb65d28d79aa#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/d8692e099f630dcb4ae9f1073ea8bb65d28d79aa#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/d8692e099f630dcb4ae9f1073ea8bb65d28d79aa#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dzmitry-lahoda given your comments, why don't we just change the internal workings of the current Rational64 type? We could keep all the same validations and signatures but change the actual type to be two Edit: We would then be able to update to |
Resolved all conversations as all the changes are the be reverted. |
This reverts commit 0ff9018, reversing changes made to 85c495d.